feat(battery): add option to show charge percentage next to the icon #994
Conversation
|
Is it me or the y axis is not centered? |
|
I've discovered that this causes the panel to resize when it's in vertical mode, it's probably not something that should be happening due to a widget, will try to check it out later |
|
Looking forward to this |
|
I'm looking forward to this as well. @ilya-zlobintsev , is there anything I can do to help this pull request get merged? |
|
Apologies, I've forgot about this PR as I'm not currently actively using cosmic on my laptop 😅 I've updated it from latest master now and fixed the size/padding, so it doesn't cause any resizing in either horizontal or vertical mode, and looks consistent with other applets. 
|
cosmic-applet-battery/src/app.rs
Outdated
| .into(), | ||
| PanelAnchor::Top | PanelAnchor::Bottom => Row::with_children(vec![btn, dot]) | ||
| if is_horizontal { | ||
| Row::with_children(vec![btn, dot]) |
There was a problem hiding this comment.
🤓 if Row::with_children and Column::with_children takes an impl IntoIterator, then the vec! macro isn't really needed, you could just pass the array itself
... 😅 sorry, besides that lgtm, looking forward to seeing this merged
There was a problem hiding this comment.
You're right, I changed it to from_vec instead, since that's what with_children does internally regardless.
There was a problem hiding this comment.
I think it would be better to use with_children (since that's used basically everywhere applicable). Just remove the vec!.
Closes #735
I haven't tested how the applet looks when the GPU selector is visible, as I don't currently have a hybrid graphics system, but it should be fine.